Skip to content

fix(material/dialog): use quoted keys in the animation state object #24594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

zarend
Copy link
Contributor

@zarend zarend commented Mar 15, 2022

Use quoted keys for the return value of _getAnimationState. This
resolves an internal issue.

Use quoted keys for the return value of `_getAnimationState`. This
resolves an internal issue.
@zarend zarend added G This is is related to a Google internal issue target: patch This PR is targeted for the next patch release area: material/dialog labels Mar 15, 2022
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Mar 15, 2022
@crisbeto
Copy link
Member

Bumping this to a minor since #24591 was a minor as well.

@crisbeto crisbeto added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Mar 15, 2022
@crisbeto crisbeto merged commit 575332c into angular:master Mar 15, 2022
forsti0506 pushed a commit to forsti0506/components that referenced this pull request Apr 3, 2022
…ngular#24594)

Use quoted keys for the return value of `_getAnimationState`. This
resolves an internal issue.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: material/dialog G This is is related to a Google internal issue target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants