Skip to content

refactor(material/list): remove deprecated APIs for version 13 #23327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2022

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 8, 2021

Removes the APIs that were marked for removal in version 13 in the material/list package.

BREAKING CHANGE:

  • mat-list-item-avatar CSS class has been renamed to mat-list-item-with-avatar.
  • MatSelectionListChange.option has been removed. Use MatSelectionListChange.options instead.
  • MatSelectionList.tabIndex input has been removed.
  • tabIndex parameter of the MatSelectionList constructor has been removed.
  • _focusMonitor parameter of the MatSelectionList constructor is now required.
  • getHarnessLoaderForContent has been removed from the various test item harnesses. Use getChildLoader(MatListItemSection.CONTENT) instead.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release labels Aug 8, 2021
@crisbeto crisbeto added this to the 13.0.0 milestone Aug 8, 2021
@crisbeto crisbeto requested a review from devversion August 8, 2021 11:10
@crisbeto crisbeto requested review from jelbourn and a team as code owners August 8, 2021 11:10
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 8, 2021
@crisbeto crisbeto force-pushed the v13-list-deprecations branch 2 times, most recently from 9369ef0 to 6cea924 Compare August 8, 2021 12:36
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

For breaking change PRs like this, can you add them to the tracker?

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Aug 9, 2021
@josephperrott josephperrott removed the request for review from a team August 10, 2021 18:39
@wagnermaciel
Copy link
Contributor

@crisbeto This needs to be rebased

@crisbeto crisbeto force-pushed the v13-list-deprecations branch from aec24de to b432f09 Compare September 17, 2021 14:48
@crisbeto
Copy link
Member Author

Rebased.

@andrewseguin andrewseguin removed the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 28, 2021
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 29, 2021
@crisbeto crisbeto force-pushed the v13-list-deprecations branch from b432f09 to 33d7418 Compare January 3, 2022 09:14
Removes the APIs that were marked for removal in version 13 in the `material/list` package.

BREAKING CHANGE:
* `mat-list-item-avatar` CSS class has been renamed to `mat-list-item-with-avatar`.
* `MatSelectionListChange.option` has been removed. Use `MatSelectionListChange.options` instead.
* `MatSelectionList.tabIndex` input has been removed.
* `tabIndex` parameter of the `MatSelectionList` constructor has been removed.
* `_focusMonitor` parameter of the `MatSelectionList` constructor is now required.
* `getHarnessLoaderForContent` has been removed from the various test item harnesses. Use `getChildLoader(MatListItemSection.CONTENT)` instead.
@crisbeto crisbeto force-pushed the v13-list-deprecations branch from 33d7418 to 4dbe8bf Compare March 5, 2022 10:16
@crisbeto crisbeto requested a review from andrewseguin as a code owner March 5, 2022 10:16
@crisbeto crisbeto merged commit 2fc6b92 into angular:master Mar 5, 2022
forsti0506 pushed a commit to forsti0506/components that referenced this pull request Apr 3, 2022
…ar#23327)

Removes the APIs that were marked for removal in version 13 in the `material/list` package.

BREAKING CHANGE:
* `mat-list-item-avatar` CSS class has been renamed to `mat-list-item-with-avatar`.
* `MatSelectionListChange.option` has been removed. Use `MatSelectionListChange.options` instead.
* `MatSelectionList.tabIndex` input has been removed.
* `tabIndex` parameter of the `MatSelectionList` constructor has been removed.
* `_focusMonitor` parameter of the `MatSelectionList` constructor is now required.
* `getHarnessLoaderForContent` has been removed from the various test item harnesses. Use `getChildLoader(MatListItemSection.CONTENT)` instead.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants