Skip to content

fix(material-experimental/mdc-slider): expose theming mixins #22764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2021
Merged

fix(material-experimental/mdc-slider): expose theming mixins #22764

merged 1 commit into from
May 25, 2021

Conversation

crisbeto
Copy link
Member

  • Fixes that the MDC slider wasn't exposing its theming mixins publicly.
  • Updates the docs for the MDC button to the new theming API.

@crisbeto
fix(material-experimental/mdc-slider): expose theming mixins
397f9da 
* Fixes that the MDC slider wasn't exposing its theming mixins publicly.
* Updates the docs for the MDC button to the new theming API.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround merge safe target: minor This PR is targeted for the next minor release labels May 23, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 23, 2021
@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label May 25, 2021
jelbourn
jelbourn approved these changes May 25, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wagnermaciel wagnermaciel merged commit 0de3f72 into angular:master May 25, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin andrewseguin approved these changes

@devversion devversion Awaiting requested review from devversion

@wagnermaciel wagnermaciel Awaiting requested review from wagnermaciel

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @andrewseguin @wagnermaciel