fix(cdk/scrolling): Prevents NaN being returned as firstVisibleIndex. - #21505
Merged
Conversation
google-cla
Bot
added
the
cla: yes
Bjeaurn
changed the title
Bjeaurn
changed the title
When firstVisibleIndex divides by zero, which can happen when the page is built and loaded dynamically; the NaN result will be used in other calculations. This then throws off things like the `newRange.start` value also returning NaN, breaking the plugin.
crisbeto
added
action: merge
andrewseguin
approved these changes
Jan 8, 2021
annieyw
pushed a commit
that referenced
this pull request
Jan 9, 2021
…#21505) When firstVisibleIndex divides by zero, which can happen when the page is built and loaded dynamically; the NaN result will be used in other calculations. This then throws off things like the `newRange.start` value also returning NaN, breaking the plugin. (cherry picked from commit 390afca)
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Jan 14, 2021
…angular#21505) When firstVisibleIndex divides by zero, which can happen when the page is built and loaded dynamically; the NaN result will be used in other calculations. This then throws off things like the `newRange.start` value also returning NaN, breaking the plugin.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When firstVisibleIndex divides by zero, which can happen when the page is built and loaded dynamically; the NaN result will be used in other calculations.
This then throws off things like the
newRange.startvalue also returning NaN, breaking the plugin.