Skip to content

fix(material-experimental/mdc-list): not accounting for global ripple options - #21393

Merged
mmalerba merged 1 commit into
angular:masterfrom
crisbeto:mdc-list-global-ripple
Jan 14, 2021
Merged

fix(material-experimental/mdc-list): not accounting for global ripple options#21393
mmalerba merged 1 commit into
angular:masterfrom
crisbeto:mdc-list-global-ripple

Conversation

@crisbeto

Copy link
Copy Markdown
Member

Fixes that the MDC-based list doesn't disable its ripples when they have been disabled globally.

… options

Fixes that the MDC-based list doesn't disable its ripples when they have been disabled globally.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Dec 18, 2020
@google-cla google-cla Bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 18, 2020

@mmalerba mmalerba left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Jan 5, 2021
@mmalerba mmalerba added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jan 14, 2021
@mmalerba
mmalerba merged commit 4be7d15 into angular:master Jan 14, 2021
mmalerba pushed a commit that referenced this pull request Jan 14, 2021
… options (#21393)

Fixes that the MDC-based list doesn't disable its ripples when they have been disabled globally.
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Feb 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants