Skip to content

fix(material-experimental/mdc-progress-spinner): indeterminate animation not working #21391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
annieyw merged 1 commit into from
Jan 6, 2021
Merged

fix(material-experimental/mdc-progress-spinner): indeterminate animation not working #21391

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 18 additions & 8 deletions src/material-experimental/mdc-progress-spinner/progress-spinner.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,28 @@
@import '@material/circular-progress/mixins.import';
@import '../mdc-helpers/mdc-helpers';

@include mdc-circular-progress-core-styles($query: $mat-base-styles-without-animation-query);
@include mdc-circular-progress-core-styles($query: $mat-base-styles-query);

.mat-mdc-progress-spinner {
// Prevents the spinning of the inner element from affecting layout outside of the spinner.
overflow: hidden;
}

.mat-mdc-progress-spinner:not(._mat-animation-noopable) {
@include mdc-circular-progress-core-styles($query: animation);
}
&._mat-animation-noopable {
&, .mdc-circular-progress__determinate-circle {
// The spinner itself has a transition on `opacity`.
transition: none;
}

.mdc-circular-progress__indeterminate-circle-graphic,
.mdc-circular-progress__spinner-layer,
.mdc-circular-progress__indeterminate-container {
// Disables the rotation animations.
animation: none;
}

// Render the indeterminate spinner as a complete circle when animations are off
._mat-animation-noopable .mdc-circular-progress__indeterminate-container circle {
stroke-dasharray: 0 !important;
.mdc-circular-progress__indeterminate-container circle {
// Render the indeterminate spinner as a complete circle when animations are off
stroke-dasharray: 0 !important;
}
}
}