bugfix: modified table predicate filter

[daniel-brenot]

Replaces the string concatenation and index search with the .some check and a contains check. This should not be less efficient since the data is only getting checked once per row instead of twice, and the row will stop being looped over if a match is found earlier. Also removes unlikely edge case of a user inputing an obscure unicode character.

[andrewseguin]

Performance-wise, I'm concerned that it's more expensive to call toLowerCase and includes for each column instead of once for each row after concatenating the values together. I'm sure the difference is small for most tables, but the solution may not scale to tables with many columns

[daniel-brenot]

I will run a performance benchmark in an online benchmark comparison and post a link

[daniel-brenot]

After testing using JSBench i have found the original algorithm to be 68% slower on average in the tests I made, on my machine. This is due to the overhead string concatenation as well as running toLowerCase and trim on a larger string being higher than the overhead of calling the function on each column(function call overhead in v8 is quite low when called in succession). You can confirm with the following jsbench snippet: https://jsbench.me/4bkjp85g44/1

[daniel-brenot]

Bumping because of inactivity.

[andrewseguin]

@daniel-brenot Sorry for the inactivity - the change looks okay to me and we can run it by internal tests to confirm that it works well. Can you rebase?

[daniel-brenot]

I pulled the upstream into the the branch and it should be good now. Let me know if theres anything else i need to do.

[andrewseguin]

I'm still seeing a note that "This branch cannot be rebased due to conflicts". You may want to perform a rebase with the original commit

[andrewseguin]

Will try to land this in #30172

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}