Skip to content

fix(material-experimental/mdc-button): fix ripple noop animation #21360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mmalerba merged 1 commit into from
Dec 17, 2020
Merged

fix(material-experimental/mdc-button): fix ripple noop animation #21360

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/material-experimental/mdc-button/button-base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,10 @@ export const _MatButtonBaseMixin: CanDisableRippleCtor&CanDisableCtor&CanColorCt
export class MatButtonBase extends _MatButtonBaseMixin implements CanDisable, CanColor,
CanDisableRipple {
/** The ripple animation configuration to use for the buttons. */
_rippleAnimation: RippleAnimationConfig = RIPPLE_ANIMATION_CONFIG;
_rippleAnimation: RippleAnimationConfig =
this._animationMode === 'NoopAnimations' ?
{enterDuration: 0, exitDuration: 0} :
RIPPLE_ANIMATION_CONFIG;

/** Whether the ripple is centered on the button. */
_isRippleCentered = false;
Expand Down