fix(material-experimental/mdc-select): panel losing max-height if menu is opened after select - #21341
Merged
Merged
Conversation
…u is opened after select If an MDC-based `mat-menu` is opened after a `mat-select`, the select will lose its `max-height`, because its selector specificity is too low and it gets overwritten by the menu which uses the same set of mixins. These changes resolve the issue by increasing the specificity.
crisbeto
added
P3
google-cla
Bot
added
the
cla: yes
annieyw
approved these changes
Dec 14, 2020
mmalerba
pushed a commit
that referenced
this pull request
Dec 17, 2020
…u is opened after select (#21341) If an MDC-based `mat-menu` is opened after a `mat-select`, the select will lose its `max-height`, because its selector specificity is too low and it gets overwritten by the menu which uses the same set of mixins. These changes resolve the issue by increasing the specificity. (cherry picked from commit c530067)
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Dec 18, 2020
…if menu is opened after autocomplete Along the same lines as angular#21341. If an MDC-based mat-menu is opened after a mat-autocomplete, the autocomplete will lose its max-height, because its selector specificity is too low and it gets overwritten by the menu which uses the same set of mixins. These changes resolve the issue by increasing the specificity.
annieyw
pushed a commit
that referenced
this pull request
Jan 6, 2021
…if menu is opened after autocomplete (#21394) Along the same lines as #21341. If an MDC-based mat-menu is opened after a mat-autocomplete, the autocomplete will lose its max-height, because its selector specificity is too low and it gets overwritten by the menu which uses the same set of mixins. These changes resolve the issue by increasing the specificity.
annieyw
pushed a commit
that referenced
this pull request
Jan 6, 2021
…if menu is opened after autocomplete (#21394) Along the same lines as #21341. If an MDC-based mat-menu is opened after a mat-autocomplete, the autocomplete will lose its max-height, because its selector specificity is too low and it gets overwritten by the menu which uses the same set of mixins. These changes resolve the issue by increasing the specificity. (cherry picked from commit 3335a92)
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Jan 14, 2021
…u is opened after select (angular#21341) If an MDC-based `mat-menu` is opened after a `mat-select`, the select will lose its `max-height`, because its selector specificity is too low and it gets overwritten by the menu which uses the same set of mixins. These changes resolve the issue by increasing the specificity.
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Jan 14, 2021
…if menu is opened after autocomplete (angular#21394) Along the same lines as angular#21341. If an MDC-based mat-menu is opened after a mat-autocomplete, the autocomplete will lose its max-height, because its selector specificity is too low and it gets overwritten by the menu which uses the same set of mixins. These changes resolve the issue by increasing the specificity.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an MDC-based
mat-menuis opened after amat-select, the select will lose itsmax-height, because its selector specificity is too low and it gets overwritten by the menu which uses the same set of mixins.These changes resolve the issue by increasing the specificity.