Skip to content

fix(material/select): incorrect default typeahead debounce time - #21253

Merged
wagnermaciel merged 1 commit into
angular:masterfrom
crisbeto:21242/select-default-typeahead
Dec 10, 2020
Merged

fix(material/select): incorrect default typeahead debounce time#21253
wagnermaciel merged 1 commit into
angular:masterfrom
crisbeto:21242/select-default-typeahead

Conversation

@crisbeto

@crisbeto crisbeto commented Dec 8, 2020

Copy link
Copy Markdown
Member

In 17a9ad0 some logic was added that was setting the typeahead debounce interval to 0 if it isn't specified globally. This is incorrect, because we want it to stay undefined so the list key manager can fall back to its default interval.

Fixes #21242.

In 17a9ad0 so logic was added that was
setting the typeahead debounce interval to 0 if it isn't specified globally.
This is incorrect, because we want it to stay undefined so the list key manager
can fall back to its default interval.

Fixes angular#21242.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release labels Dec 8, 2020
@google-cla google-cla Bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 8, 2020

@mmalerba mmalerba left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Dec 9, 2020
@wagnermaciel
wagnermaciel merged commit ab01f38 into angular:master Dec 10, 2020
wagnermaciel pushed a commit that referenced this pull request Dec 10, 2020
In 17a9ad0 so logic was added that was
setting the typeahead debounce interval to 0 if it isn't specified globally.
This is incorrect, because we want it to stay undefined so the list key manager
can fall back to its default interval.

Fixes #21242.

(cherry picked from commit ab01f38)
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Jan 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(select): typeahead with more than one character does not select the right option

3 participants