fix(material/menu): set correct focus origin on item when opened via keyboard - #21252
Merged
Merged
Conversation
crisbeto
added
P3
google-cla
Bot
added
the
cla: yes
crisbeto
force-pushed
the
21241/menu-keyboard-origin
branch
from
December 8, 2020 21:01
111aa38 to
8e09d85
Compare
zelliott
reviewed
Dec 9, 2020
zelliott
reviewed
Dec 9, 2020
Contributor
|
Left two minor comments, otherwise LGTM. |
crisbeto
force-pushed
the
21241/menu-keyboard-origin
branch
from
December 9, 2020 17:30
8e09d85 to
1130d09
Compare
…keyboard Fixes that we were setting the `program` focus origin on the first menu item, even though the user opened it using the keyboard. Fixes angular#21241.
crisbeto
force-pushed
the
21241/menu-keyboard-origin
branch
from
December 9, 2020 18:26
1130d09 to
e4f254e
Compare
Contributor
|
@annieyw Any update on this? Thanks! |
|
Thanks for fixing this @crisbeto ! I'm looking forward to this as it will unblock some a11y work we're doing. |
jelbourn
added
Accessibility
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Jan 14, 2021
…keyboard (angular#21252) Fixes that we were setting the `program` focus origin on the first menu item, even though the user opened it using the keyboard. Fixes angular#21241.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes that we were setting the
programfocus origin on the first menu item, even though the user opened it using the keyboard.Fixes #21241.