Skip to content

fix(material/menu): prevent mat-menu from affecting flex layout - #21246

Merged
annieyw merged 1 commit into
angular:masterfrom
annieyw:mat-menu-flex
Feb 7, 2021
Merged

fix(material/menu): prevent mat-menu from affecting flex layout#21246
annieyw merged 1 commit into
angular:masterfrom
annieyw:mat-menu-flex

Conversation

@annieyw

@annieyw annieyw commented Dec 8, 2020

Copy link
Copy Markdown
Contributor

Fixes #21182

@annieyw annieyw added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent G This is is related to a Google internal issue target: patch This PR is targeted for the next patch release labels Dec 8, 2020
@google-cla google-cla Bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 8, 2020
crisbeto
crisbeto approved these changes Dec 8, 2020
View reviewed changes

@crisbeto crisbeto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Dec 8, 2020
jelbourn
jelbourn approved these changes Dec 9, 2020
View reviewed changes

@jelbourn jelbourn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto this probably makes the clearing of aria attribute on this element unnecessary... I'm not sure why I didn't think of it sooner

crisbeto added a commit to crisbeto/material2 that referenced this pull request Jan 20, 2021
@crisbeto
fix(material/autocomplete): prevent inert host node from affecting su…
e43eaba 
…rrounding layout

Similar to angular#21246. Prevents the inert host node for `mat-autocomplete` from affecting
the layout around it.
@crisbeto crisbeto mentioned this pull request Jan 20, 2021
Merged
andrewseguin pushed a commit that referenced this pull request Jan 25, 2021
@crisbeto
fix(material/autocomplete): prevent inert host node from affecting su…
3bbc0a0 
…rrounding layout (#21649)

Similar to #21246. Prevents the inert host node for `mat-autocomplete` from affecting
the layout around it.
andrewseguin pushed a commit that referenced this pull request Jan 25, 2021
@crisbeto @andrewseguin
fix(material/autocomplete): prevent inert host node from affecting su…
9c99070 
…rrounding layout (#21649)

Similar to #21246. Prevents the inert host node for `mat-autocomplete` from affecting
the layout around it.

(cherry picked from commit 3bbc0a0)
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Jan 26, 2021
@crisbeto @wagnermaciel
fix(material/autocomplete): prevent inert host node from affecting su…
68a475f 
…rrounding layout (angular#21649)

Similar to angular#21246. Prevents the inert host node for `mat-autocomplete` from affecting
the layout around it.
mmalerba pushed a commit to mmalerba/components that referenced this pull request Jan 29, 2021
@crisbeto @mmalerba
fix(material/autocomplete): prevent inert host node from affecting su…
23873a4 
…rrounding layout (angular#21649)

Similar to angular#21246. Prevents the inert host node for `mat-autocomplete` from affecting
the layout around it.
@annieyw
annieyw merged commit 510672e into angular:master Feb 7, 2021
annieyw added a commit that referenced this pull request Feb 7, 2021
@annieyw
fix(material/menu): prevent mat-menu from affecting flex layout (#21246)
d90dc9c 
(cherry picked from commit 510672e)
annieyw added a commit that referenced this pull request Feb 7, 2021
@annieyw
fix(material/menu): prevent mat-menu from affecting flex layout (#21246)
1c16d91 
(cherry picked from commit 510672e)
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Feb 8, 2021
@crisbeto @wagnermaciel
fix(material/autocomplete): prevent inert host node from affecting su…
fb13780 
…rrounding layout (angular#21649)

Similar to angular#21246. Prevents the inert host node for `mat-autocomplete` from affecting
the layout around it.
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Feb 8, 2021
@annieyw @wagnermaciel
fix(material/menu): prevent mat-menu from affecting flex layout (angu…
63548ea 
…lar#21246)
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Feb 8, 2021
@crisbeto @wagnermaciel
fix(material/autocomplete): prevent inert host node from affecting su…
37653ff 
…rrounding layout (angular#21649)

Similar to angular#21246. Prevents the inert host node for `mat-autocomplete` from affecting
the layout around it.
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Feb 8, 2021
@annieyw @wagnermaciel
fix(material/menu): prevent mat-menu from affecting flex layout (angu…
7c5f976 
…lar#21246)
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Mar 10, 2021

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Mar 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes
@mmalerba mmalerba Awaiting requested review from mmalerba
+1 more reviewer
@jelbourn jelbourn jelbourn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug(MatMenu): empty element not removed/hidden from DOM breaks flex layouts

3 participants

@annieyw @jelbourn @crisbeto