fix(material-experimental/mdc-form-field): make sure fonts are loaded… - #21245
Merged
Conversation
crisbeto
reviewed
Dec 8, 2020
mmalerba
reviewed
Dec 8, 2020
Contributor
Author
|
Contributor
Author
… before calculating notch width
Contributor
Author
|
Some tweaks to make sure this change works in async tests as zone.js doesn't patch the FontFaceSet API and to account for really slow connections. |
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Jan 14, 2021
… before calculating notch width (angular#21245)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

… before calculating notch width
The label width was being calculated before the fonts were loaded which caused the label to be cut off sometimes. By calculating the width after
fonts.readyresolves we can be sure that the label will be the correct size.Note that the workaround for IE is not perfect as depending on the connection speed the font still might not be loaded after the time out.
Before:

After:
