Skip to content

fix(material/menu): clear static aria attributes from host node - #21231

Merged
wagnermaciel merged 1 commit into
angular:masterfrom
crisbeto:21152/menu-static-aria
Dec 8, 2020
Merged

fix(material/menu): clear static aria attributes from host node#21231
wagnermaciel merged 1 commit into
angular:masterfrom
crisbeto:21152/menu-static-aria

Conversation

@crisbeto

@crisbeto crisbeto commented Dec 6, 2020

Copy link
Copy Markdown
Member

Clears the static aria- attributes from the menu host since they're forwarded to the menu overlay panel.

Fixes #21152.

@crisbeto
fix(material/menu): clear static aria attributes from host node
ca8795e 
Clears the static `aria-` attributes from the menu host since they're forwarded
to the menu overlay panel.

Fixes angular#21152.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Dec 6, 2020
@google-cla google-cla Bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 6, 2020
jelbourn
jelbourn approved these changes Dec 7, 2020
View reviewed changes

@jelbourn jelbourn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Dec 7, 2020
@wagnermaciel
wagnermaciel merged commit 377378b into angular:master Dec 8, 2020
wagnermaciel pushed a commit that referenced this pull request Dec 8, 2020
@crisbeto @wagnermaciel
fix(material/menu): clear static aria attributes from host node (#21231)
f568af1 
Clears the static `aria-` attributes from the menu host since they're forwarded
to the menu overlay panel.

Fixes #21152.

(cherry picked from commit 377378b)
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Jan 8, 2021

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Jan 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@jelbourn jelbourn jelbourn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@jelbourn jelbourn

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MatMenu aria-label is not cleared from dummy element

3 participants

@crisbeto @jelbourn @wagnermaciel