Skip to content

fix(material-experimental/radio): include form field styles in mdc-radio theme - #21168

Merged
mmalerba merged 1 commit into
angular:masterfrom
mitchellwills:master
Dec 4, 2020
Merged

fix(material-experimental/radio): include form field styles in mdc-radio theme#21168
mmalerba merged 1 commit into
angular:masterfrom
mitchellwills:master

Conversation

@mitchellwills

@mitchellwills mitchellwills commented Nov 29, 2020

Copy link
Copy Markdown
Contributor

This mirrors how they are included in mdc-checkbox. Without this the radio label isn't styled.

@google-cla google-cla Bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 29, 2020
@mitchellwills
fix(material-experimental/mdc-radio): include form field styles in md…
6d2d105 
…c-radio theme

This mirrors how they are included in mdc-checkbox. Without this the radio label
isn't styled.
mmalerba
mmalerba approved these changes Dec 1, 2020
View reviewed changes

@mmalerba mmalerba left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added G This is is related to a Google internal issue action: merge The PR is ready for merge by the caretaker P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release labels Dec 1, 2020
@mmalerba
mmalerba merged commit 5a28f00 into angular:master Dec 4, 2020
mmalerba pushed a commit that referenced this pull request Dec 4, 2020
@mitchellwills @mmalerba
fix(material-experimental/mdc-radio): include form field styles in md…
0aa94ac 
…c-radio theme (#21168)

This mirrors how they are included in mdc-checkbox. Without this the radio label
isn't styled.

(cherry picked from commit 5a28f00)
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Jan 4, 2021

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Jan 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@mmalerba mmalerba mmalerba approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mitchellwills @mmalerba