feat(material-experimental/mdc-slider): WIP implement the basics for … #21165
Conversation
google-cla
bot
added
the
cla: yes
wagnermaciel
force-pushed
the
mdc-slider
branch
5 times, most recently
from
4cfcec2 to
fcfccf4
Compare
wagnermaciel
force-pushed
the
mdc-slider
branch
from
fcfccf4 to
2e9cc67
Compare
|
I haven't started working on making this backwards compatible yet. Also, this is a pretty massive change so I'm happy to stretch this into multiple commits or PRs or whatever ya'll prefer |
| <h1>Default Slider</h1> | ||
| Label <mat-slider #slidey aria-label="Basic slider"></mat-slider> | ||
| {{slidey.value}} | ||
| <p>Continuous slider</p> |
There was a problem hiding this comment.
Usually we leave the mdc demo pretty much the same as the non-mdc demo. That way we can verify that all the same usages still work. Is there a reason you changed it so much here?
There was a problem hiding this comment.
Yeah, I wanted to test each of the different ways the slider could be used. I'll revert this once I'm done testing. For now I'll add a todo to remember to do so
| '[min]': 'min', | ||
| '[max]': 'max', | ||
| '[step]': 'step', | ||
| '[attr.value]': 'value', |
There was a problem hiding this comment.
Does [value] not work? (if no, we should have a comment that explains why)
| registerWindowEventHandler: () => {}, | ||
| deregisterWindowEventHandler: () => {}, | ||
| removeTrackActiveStyleProperty: (_propertyName: string) => {}, | ||
| hasClass: (_className: string) => { |
There was a problem hiding this comment.
Can you extract this adapter out into a standalone class? See this PR for a reference #19980
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
…mdc slider