Skip to content

fix(material/radio): group selected button not set for preselected control value - #21154

Merged
mmalerba merged 1 commit into
angular:masterfrom
crisbeto:21148/radio-preselected
Dec 4, 2020
Merged

fix(material/radio): group selected button not set for preselected control value#21154
mmalerba merged 1 commit into
angular:masterfrom
crisbeto:21148/radio-preselected

Conversation

@crisbeto

@crisbeto crisbeto commented Nov 26, 2020

Copy link
Copy Markdown
Member

Fixes that MatRadioGroup.selected wasn't set if the value is assigned on init through a ControlValueAccessor.

Fixes #21148.

@crisbeto
fix(material/radio): group selected button not set for preselected co…
a4e350d 
…ntrol value

Fixes that `MatRadioGroup.selected` wasn't set if the value is assigned on init through a `ControlValueAccessor`.

Fixes angular#21148.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Nov 26, 2020
@google-cla google-cla Bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 26, 2020
jelbourn
jelbourn approved these changes Nov 30, 2020
View reviewed changes

@jelbourn jelbourn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Nov 30, 2020
@mmalerba
mmalerba merged commit 6cd1dbe into angular:master Dec 4, 2020
mmalerba pushed a commit that referenced this pull request Dec 4, 2020
@crisbeto @mmalerba
fix(material/radio): group selected button not set for preselected co…
3194a3e 
…ntrol value (#21154)

Fixes that `MatRadioGroup.selected` wasn't set if the value is assigned on init through a `ControlValueAccessor`.

Fixes #21148.

(cherry picked from commit 6cd1dbe)
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Jan 4, 2021

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Jan 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devversion devversion Awaiting requested review from devversion
@mmalerba mmalerba Awaiting requested review from mmalerba
1 more reviewer
@jelbourn jelbourn jelbourn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@mmalerba mmalerba

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug(radio): radio group selected not set in Ivy on initialization

3 participants

@crisbeto @jelbourn @mmalerba