Skip to content

fix(cdk/observers): incorrect coercion member type - #21116

Merged
mmalerba merged 1 commit into
angular:masterfrom
crisbeto:21101/wrong-coercion
Dec 3, 2020
Merged

fix(cdk/observers): incorrect coercion member type#21116
mmalerba merged 1 commit into
angular:masterfrom
crisbeto:21101/wrong-coercion

Conversation

@crisbeto

@crisbeto crisbeto commented Nov 22, 2020

Copy link
Copy Markdown
Member

Fixes that the ngAcceptInputType_debounce was typed as a boolean input, even though it's a number.

Fixes #21101.

@crisbeto
fix(cdk/observers): incorrect coercion member type
cfc1c63 
Fixes that the `ngAcceptInputType_debounce` was typed as a boolean input, even
though it's a number.

Fixes angular#21101.
@crisbeto crisbeto added P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release labels Nov 22, 2020
@crisbeto
crisbeto requested a review from jelbourn as a code owner November 22, 2020 15:40
@google-cla google-cla Bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 22, 2020
jelbourn
jelbourn approved these changes Nov 25, 2020
View reviewed changes

@jelbourn jelbourn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent and removed P4 A relatively minor issue that is not relevant to core functions labels Nov 25, 2020
@mmalerba
mmalerba merged commit 015ac3f into angular:master Dec 3, 2020
mmalerba pushed a commit that referenced this pull request Dec 3, 2020
@crisbeto @mmalerba
fix(cdk/observers): incorrect coercion member type (#21116)
5921859 
Fixes that the `ngAcceptInputType_debounce` was typed as a boolean input, even
though it's a number.

Fixes #21101.

(cherry picked from commit 015ac3f)
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Jan 3, 2021

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Jan 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@jelbourn jelbourn jelbourn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@annieyw annieyw

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug(CdkObserveContent): Incorrect typing for CdkObserveContent's [debounce] property

4 participants

@crisbeto @jelbourn @mmalerba @annieyw