feat(material/sidenav): add test harnesses for container and content elements - #21115
Merged
Merged
Conversation
…elements * Adds test harnesses for `MatDrawerContainer`, `MatDrawerContent`, `MatSidenavContainer` and `MatSidenavContent`. This came up during the original PR review (angular#16695), but we never followed up on it. * Fixes that `MatSidenavHarness.with` was returning a `MatDrawerHarness`. I had to move all the common code into a new class called `MatDrawerHarnessBase` so TS doesn't complain that the types don't match up.
crisbeto
added
P3
google-cla
Bot
added
the
cla: yes
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MatDrawerContainer,MatDrawerContent,MatSidenavContainerandMatSidenavContent. This came up during the original PR review (feat(material-experimental): add sidenav test harness #16695), but we never followed up on it.MatSidenavHarness.withwas returning aMatDrawerHarness. I had to move all the common code into a new class calledMatDrawerHarnessBaseso TS doesn't complain that the types don't match up.