feat(material/datepicker) allow custom pickers with date inputs - #20864
Merged
annieyw merged 1 commit intoNov 4, 2020
Merged
Conversation
google-cla
Bot
added
the
cla: yes
MichaelJamesParsons
force-pushed
the
datepicker-custom-picker-panels
branch
from
October 22, 2020 21:52
36773a0 to
dc8c7bb
Compare
MichaelJamesParsons
added
area: material/datepicker
G
jelbourn
reviewed
Oct 22, 2020
MichaelJamesParsons
force-pushed
the
datepicker-custom-picker-panels
branch
4 times, most recently
from
October 23, 2020 03:19
a963660 to
75b1ce0
Compare
crisbeto
reviewed
Oct 23, 2020
jelbourn
reviewed
Oct 26, 2020
| openedStream: EventEmitter<void>; | ||
| stateChanges: Subject<void>; | ||
| open(): void; | ||
| registerInput(input: C): MatDateSelectionModel<S, D>; |
Contributor
There was a problem hiding this comment.
Since this is a public API, each of these members need a JsDoc description (these are auto generated into material.angular.io)
mmalerba
approved these changes
Oct 27, 2020
mmalerba
left a comment
mmalerba
left a comment
Contributor
There was a problem hiding this comment.
LGTM after Jeremy's comment is addressed
MichaelJamesParsons
force-pushed
the
datepicker-custom-picker-panels
branch
from
October 27, 2020 19:57
75b1ce0 to
1648eea
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor material datepicker so apps can bind custom picker components to date inputs.
API changes
MatDatepickerBase:_registerInput()->registerInput()_stateChanges->stateChanges_datepickerInput->datepickerInputMatDatepickerPanelinterface (recommendations for another name?).MatDatepickerInput,MatDateRangeInput, andMatDatepickerToggleto receive aMatDatepickerPanelinstead of a specific implementation ofMatDatepickerBase.