Skip to content

fix(material-experimental/mdc-button): align public API with material/button #20679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2020
Merged

fix(material-experimental/mdc-button): align public API with material/button #20679

merged 1 commit into from
Sep 30, 2020

Conversation

crisbeto
Copy link
Member

Aligns the signature of the focus method between the MDC and non-MDC buttons to make updates easier.

@crisbeto
fix(material-experimental/mdc-button): align public API with material…
75c0277 
…/button

Aligns the signature of the `focus` method between the MDC and non-MDC buttons to make updates easier.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: patch This PR is targeted for the next patch release labels Sep 29, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 29, 2020
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Sep 30, 2020
@mmalerba mmalerba merged commit 55b74e3 into angular:master Sep 30, 2020
mmalerba pushed a commit that referenced this pull request Sep 30, 2020
@crisbeto @mmalerba
fix(material-experimental/mdc-button): align public API with material…
3a34ab0 
…/button (#20679)

Aligns the signature of the `focus` method between the MDC and non-MDC buttons to make updates easier.

(cherry picked from commit 55b74e3)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@annieyw annieyw annieyw approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@mmalerba mmalerba

@annieyw annieyw

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @annieyw @googlebot @mmalerba