perf(material-experimental/mdc-progress-bar): Use class for MDC adapter #20088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
mmalerba
changed the title
|
Are the checkbox changes here intentionally or was that some kind of bad rebase? |
mmalerba
reviewed
Jul 27, 2020
|
@mmalerba I accidentally left changes in checkbox and radio on my branch - should be gone now. |
|
still seeing checkbox and radio changes |
ngwattcos
force-pushed
the
optimize-progress-bar
branch
from
bc32873 to
b9fd9b4
Compare
|
@mmalerba I accidentally committed all files again. Silly me! Should be fixed now. |
ngwattcos
force-pushed
the
optimize-progress-bar
branch
from
b9fd9b4 to
256ff6e
Compare
|
It looks like there are some failing tests |
andrewseguin
removed
the
cla: yes
|
Closing due to inactivity |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates mdc-progress-bar to use a class-based adapter, which improves performance, just like in:
#19980
Hopefully, test failures will be resolved after this PR is merged:
material-components/material-components-web#6256