perf(material-experimental/mdc-snackbar): Use class for adapter #20087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
reviewed
Jul 25, 2020
There was a problem hiding this comment.
- The PR description is talking about the snack bar, but this includes changes to the checkbox and radio button.
- There are some test failures that need to be resolved.
- Either everything should be squashed under
perfcommit or the PR should be renamed to includeperf(material-experimental/mdc-snackbar), otherwise the title will be incorrect when the caretaker squashes the commits.
|
@crisbeto Yikes, not sure what happened here. I'll fix this asap |
kseamon
reviewed
Jul 27, 2020
| @@ -248,7 +267,8 @@ export class MatCheckbox implements AfterViewInit, OnDestroy, ControlValueAccess | |||
| // Note: We don't need to set up the MDCFormFieldFoundation. Its only purpose is to manage the | |||
| // ripple, which we do ourselves instead. | |||
| this.tabIndex = parseInt(tabIndex) || 0; | |||
| this._checkboxFoundation = new MDCCheckboxFoundation(this._checkboxAdapter); | |||
| this._adapter = new CheckBoxAdapter(this); | |||
| } | ||
| }, | ||
| }; | ||
| private _radioAdapter: MDCRadioAdapter; |
|
Note: The tests on this PR are going to fail until material-components/material-components-web#6256 is in effect on the MDC side. |
…performance and decrease memory usage
ngwattcos
force-pushed
the
optimize-snack-bar
branch
from
e1f27b3 to
2695e01
Compare
mmalerba
changed the title
mmalerba
added
lgtm
action: merge
andrewseguin
removed
the
cla: yes
|
We will soon be taking out our dependency on the adapters provided by MDC since they won't be supported later. Thank you for your contribution, sorry we weren't able to land this |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates mdc-snack-bar-container to use a class-based adapter, which improves performance, just like in:
#19980
Hopefully, test failures will be resolved after this PR is merged:
material-components/material-components-web#6256