fix(material-experimental/chips): fix empty check when no chips - #20025
Merged
Conversation
googlebot
added
the
cla: yes
andrewseguin
added
P2
googlebot
added
the
cla: yes
andrewseguin
added
the
target: patch
crisbeto
reviewed
Jul 17, 2020
| * @docs-private | ||
| */ | ||
| get empty(): boolean { return this._chipInput.empty && this._chips.length === 0; } | ||
| get empty(): boolean { return this._chipInput.empty && (!this._chips || this._chips.length === 0); } |
Member
There was a problem hiding this comment.
Should we null check for the _chipInput too? AFAIK it's not guaranteed to be defined either.
Contributor
Author
There was a problem hiding this comment.
Probably should - just wasn't an issue internally. I added a change to include that too
andrewseguin
added a commit
that referenced
this pull request
Jul 17, 2020
* fix(material-experimental/chips): fix empty check when no chips * same for chipset * check for input too (cherry picked from commit ebda4de)
ngwattcos
pushed a commit
to ngwattcos/components
that referenced
this pull request
Jul 20, 2020
…lar#20025) * fix(material-experimental/chips): fix empty check when no chips * same for chipset * check for input too
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar check that was necessitated from PR #10466 - due to changes in the change detection cycle from input, its possible that
emptyis called earlier and should account for when there are nochipspicked up yet