perf(int-bar): Convert MatInkBarFoundation adapter to class object - #19986
Conversation
Converts the adapter to class object to hopefully reduce memory usage. Adds getters to access private fields.
googlebot
added
the
cla: yes
| getDestroyed() { | ||
| return this._destroyed; | ||
| } | ||
|
|
There was a problem hiding this comment.
Instead of adding getters for all of these, we can use readonly properties instead which won't generate any extra runtime code. If we need to change one of them (e.g. destroyed), we can do something like this (this as {destroyed: boolean}).destroyed = true.
There was a problem hiding this comment.
@crisbeto So to be clear, the properties _inkBarContentElement, _hostElement, and _getDestroyed should be exposed publicly but made readonly?
crisbeto
added
lgtm
action: merge
…19986) * perf(int-bar): Convert MatInkBarFoundation adapter to class object Converts the adapter to class object to hopefully reduce memory usage. Adds getters to access private fields. * refactor(ink-bar): expose some fields and make public; remove getter methods * fix(ink-bar): fix build/typing issues in reassigning fields due to readonly (cherry picked from commit 78dc50b)
…ngular#19986) * perf(int-bar): Convert MatInkBarFoundation adapter to class object Converts the adapter to class object to hopefully reduce memory usage. Adds getters to access private fields. * refactor(ink-bar): expose some fields and make public; remove getter methods * fix(ink-bar): fix build/typing issues in reassigning fields due to readonly
…bject (angular#19986)" This reverts commit 78dc50b. This PR was marked merge-safe but caused presubmits to break. Tests were failing because the dev-app doesn't show ink bars anymore.
|
@ngwattcos It looks like this got reverted, please make the same stylistic changes I've been mentioning in your other similar PRs before it goes in again |
| } from '@material/tab-indicator'; | ||
|
|
||
| class TabIndicatorAdapter implements MDCTabIndicatorAdapter { | ||
| constructor(private readonly _delegate: MatInkBarFoundation) {} |
There was a problem hiding this comment.
As with other PRs, put newlines between methods
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
6 participants
Converts the adapter to class object to hopefully reduce memory usage. Adds getters to access private fields.