perf(mdc-chips): Use class for MDC adapter #19981
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change replaces the private adapter wth an adapter class object which should hopefully reduce memory usage.
Makes the adapter into a class in MatChipSet and MatChipListbox to hopefully improve memory usage.
googlebot
added
the
cla: yes
Updates chip adapter into a class object to reduce memory usage
mmalerba
reviewed
Jul 16, 2020
mmalerba
reviewed
Jul 16, 2020
| @@ -373,6 +389,11 @@ export class MatChip extends _MatChipMixinBase implements AfterContentInit, Afte | |||
| this._chipFoundation.destroy(); | |||
| } | |||
|
|
|||
| /** Returns the directionality */ | |||
| getDir() { | |||
There was a problem hiding this comment.
just make _dir public instead (leave the underscore in the name)
There was a problem hiding this comment.
I got another comment saying to use a method unless it's readonly in a separate PR:
#19985 (comment)
Perhaps the best way is to append an underscore so the method name is _getDir() ?
There was a problem hiding this comment.
Update: exposed _dir and made it readonly
perf(chip-set, chip-listbox) make adapter into a class
perf(chips): replace private adapter object with adapter class object
mmalerba
reviewed
Jul 20, 2020
mmalerba
reviewed
Jul 21, 2020
kseamon
reviewed
Jul 21, 2020
…ir as public readonly, resolve requests for changes on PR
mmalerba
reviewed
Jul 30, 2020
|
Code looks good, but there's some lint and test failures |
andrewseguin
removed
the
cla: yes
|
Closing due to inactivity |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert the adapters in chips, chip-set, chip-listbox, mat-chipset to class objects to hopefully reduce memory usage.
Test failures hopefully should be resolved after this PR is merged:
material-components/material-components-web#6256