Skip to content

fix(material-experimental/mdc-snack-bar): error during server-side rendering - #19922

Merged
mmalerba merged 1 commit into
angular:masterfrom
crisbeto:mdc-snack-bar-ssr
Jul 10, 2020
Merged

fix(material-experimental/mdc-snack-bar): error during server-side rendering#19922
mmalerba merged 1 commit into
angular:masterfrom
crisbeto:mdc-snack-bar-ssr

Conversation

@crisbeto

@crisbeto crisbeto commented Jul 9, 2020

Copy link
Copy Markdown
Member

Fixes an error that the MDC snack bar throws during server-side rendering, because MDC is using some browser APIs. Also sets up SSR testing for the new module.

…ndering

Fixes an error that the MDC snack bar throws during server-side rendering, because MDC is using some browser APIs. Also sets up SSR testing for the new module.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: patch This PR is targeted for the next patch release labels Jul 9, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 9, 2020
@andrewseguin andrewseguin added lgtm action: merge The PR is ready for merge by the caretaker labels Jul 9, 2020
@mmalerba
mmalerba merged commit 912ad8d into angular:master Jul 10, 2020
mmalerba pushed a commit that referenced this pull request Jul 10, 2020
…ndering (#19922)

Fixes an error that the MDC snack bar throws during server-side rendering, because MDC is using some browser APIs. Also sets up SSR testing for the new module.
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Aug 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants