fix(drag-drop): not starting auto scroll when inside boundary - #19865
Merged
Conversation
The logic that starts the auto-scrolling sequence was using the pointer position that is constrained within the boundary element which wasn't allow it to start auto scrolling. These changes also fix some internal issues that I noticed along the way: * We were using the pointer position at the last direction change to re-sort the element while dragging. This is incorrect since the user might not have changed direction. Now we use the position at the last pointer event. * The `_getConstrainedPointerPosition` method was mutating the passed in `Point` which can throw things off downstream. * The logic that updates the `ClientRect` of the boundary element was doing so on any scroll, even if it comes from inside the boundary. Now we only do it if a parent of the boundary was scrolled. Fixes angular#18596.
crisbeto
added
P3
googlebot
added
the
cla: yes
mmalerba
pushed a commit
that referenced
this pull request
Jul 8, 2020
The logic that starts the auto-scrolling sequence was using the pointer position that is constrained within the boundary element which wasn't allow it to start auto scrolling. These changes also fix some internal issues that I noticed along the way: * We were using the pointer position at the last direction change to re-sort the element while dragging. This is incorrect since the user might not have changed direction. Now we use the position at the last pointer event. * The `_getConstrainedPointerPosition` method was mutating the passed in `Point` which can throw things off downstream. * The logic that updates the `ClientRect` of the boundary element was doing so on any scroll, even if it comes from inside the boundary. Now we only do it if a parent of the boundary was scrolled. Fixes #18596.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic that starts the auto-scrolling sequence was using the pointer position that is constrained within the boundary element which wasn't allowing it to start auto scrolling. These changes also fix some internal issues that I noticed along the way:
_getConstrainedPointerPositionmethod was mutating the passed inPointwhich can throw things off downstream.ClientRectof the boundary element was doing so on any scroll, even if it comes from inside the boundary. Now we only do it if a parent of the boundary was scrolled.Fixes #18596.