Skip to content

build: enforce consistent spaces between colons #19856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2020
Merged

build: enforce consistent spaces between colons #19856

merged 1 commit into from
Jul 8, 2020

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jul 3, 2020

Enables a lint rule that enforces that we have consistent spaces around the colon which prevents things like display:none.

@crisbeto
build: enforce consistent spaces between colons
da1c46c 
Enables a lint rule that enforces that we have consistent spaces around the colon which prevents things like `display:none`.
@crisbeto crisbeto added merge safe P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release labels Jul 3, 2020
@crisbeto crisbeto requested review from devversion, jelbourn and a team as code owners July 3, 2020 20:53
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 3, 2020
@devversion devversion added lgtm action: merge The PR is ready for merge by the caretaker labels Jul 6, 2020
jelbourn
jelbourn approved these changes Jul 6, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba merged commit 74cd65a into angular:master Jul 8, 2020
mmalerba pushed a commit that referenced this pull request Jul 8, 2020
@crisbeto @mmalerba
build: enforce consistent spaces between colons (#19856)
63e322e 
Enables a lint rule that enforces that we have consistent spaces around the colon which prevents things like `display:none`.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

Assignees

@jelbourn jelbourn

@devversion devversion

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crisbeto @jelbourn @devversion @googlebot @mmalerba