build: remove workaround for decorator metadata in universal-app #19840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the past, Angular removed tsickle from the build pipeline. This meant that decorators were not downleveled, and executed immediately. This caused errors in SSR as parameters or input types are accessed on file load as runtime values. e.g. consider an input that used `HTMLElement` as type. The TypeScript decorator output would access `HTMLElement` on file load directly. This breaks on the server as such DOM specific globals do not exist there. We worked around this by providing global mocks for these symbols. Now with Angular v10 though, Angular processes decorators by default without requiring tsickle. This means that we can remove the workaround.
googlebot
added
the
cla: yes
devversion
added
merge safe
target: patch
mmalerba
pushed a commit
that referenced
this pull request
Jul 8, 2020
) In the past, Angular removed tsickle from the build pipeline. This meant that decorators were not downleveled, and executed immediately. This caused errors in SSR as parameters or input types are accessed on file load as runtime values. e.g. consider an input that used `HTMLElement` as type. The TypeScript decorator output would access `HTMLElement` on file load directly. This breaks on the server as such DOM specific globals do not exist there. We worked around this by providing global mocks for these symbols. Now with Angular v10 though, Angular processes decorators by default without requiring tsickle. This means that we can remove the workaround.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past, Angular removed tsickle from the build pipeline. This meant
that decorators were not downleveled, and executed immediately. This
caused errors in SSR as parameters or input types are accessed on
file load as runtime values. e.g. consider an input that used
HTMLElementas type. The TypeScript decorator output would accessHTMLElementon file load directly. This breaks on the server as suchDOM specific globals do not exist there.
We worked around this by providing global mocks for these symbols. Now
with Angular v10 though, Angular processes decorators by default without
requiring tsickle. This means that we can remove the workaround.