refactor(material-experimental): expose whether harness elements are focused - #19704
Merged
Merged
Conversation
…focused Currently we have a bunch of test harnesses that have methods for blurring and focusing the underlying element, but they don't expose whether it currently has focus. These changes add `isFocused` methods to all of the harnesses so they're consistent between each other. Fixes angular#19702.
googlebot
added
the
cla: yes
crisbeto
marked this pull request as ready for review
June 20, 2020 08:00
crisbeto
requested review from
andrewseguin,
devversion,
jelbourn and
mmalerba
as code owners
June 20, 2020 08:00
crisbeto
added
P3
devversion
approved these changes
Jun 22, 2020
Contributor
|
Though, @crisbeto I would categorize this as a feature |
mmalerba
added
target: minor
jelbourn
added
the
merge: fix commit message
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we have a bunch of test harnesses that have methods for blurring and focusing the underlying element, but they don't expose whether it currently has focus. These changes add
isFocusedmethods to all of the harnesses so they're consistent between each other.Fixes #19702.