Skip to content

fix(datepicker): not revalidating after value is changed through the calendar - #19695

Merged
mmalerba merged 1 commit into
angular:masterfrom
crisbeto:datepicker-external-revalidation
Jun 19, 2020
Merged

fix(datepicker): not revalidating after value is changed through the calendar#19695
mmalerba merged 1 commit into
angular:masterfrom
crisbeto:datepicker-external-revalidation

Conversation

@crisbeto

Copy link
Copy Markdown
Member

Fixes an issue where the datepicker wouldn't revalidate, if the user typed in something invalid and then selected a value through the calendar. This seems to have regressed after things were moved around to accommodate the date range picker.

…calendar

Fixes an issue where the datepicker wouldn't revalidate, if the user typed in something invalid and then selected a value through the calendar. This seems to have regressed after things were moved around to accommodate the date range picker.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release labels Jun 19, 2020
@crisbeto crisbeto added this to the 10.0.0 milestone Jun 19, 2020
@crisbeto
crisbeto requested a review from mmalerba as a code owner June 19, 2020 05:47
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 19, 2020
@crisbeto

Copy link
Copy Markdown
Member Author

This should be cherry picked into 10.0.x as well.

@mmalerba mmalerba left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release labels Jun 19, 2020
@mmalerba
mmalerba merged commit 33aeea9 into angular:master Jun 19, 2020
mmalerba pushed a commit that referenced this pull request Jun 19, 2020
…calendar (#19695)

Fixes an issue where the datepicker wouldn't revalidate, if the user typed in something invalid and then selected a value through the calendar. This seems to have regressed after things were moved around to accommodate the date range picker.
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Jul 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants