feat(cdk-experimental/menu): Add menu skeleton and build scripts - #19583
Merged
Conversation
Configure bazel scripts for a cdk menu feature along with the general structure identifying the set of directives which make it up
Configure dev-app for cdk-experimental/menu
googlebot
added
the
cla: yes
A CdkMenuItem opens a CdkMenuPanel and therefore must reference it. A CdkMenuPanel contains a CdkMenu and therefore must reference it. A CdkMenu contains CdkMenuItem's and therefore must reference it.
mmalerba
reviewed
Jun 10, 2020
devversion
reviewed
Jun 10, 2020
devversion
reviewed
Jun 10, 2020
Move from material-experimental section to cdk-experimental
literalpie
reviewed
Jun 10, 2020
teflonwaffles
approved these changes
Jun 11, 2020
jelbourn
reviewed
Jun 11, 2020
| @@ -0,0 +1,23 @@ | |||
| <ul cdkMenuBar class="example-menu-bar"> | |||
| <li role="none"><button id="file_button" [cdkMenuTriggerFor]="file">File</button></li> | |||
Contributor
There was a problem hiding this comment.
Not in this PR, but at some point I want to sit down and think about the way we're using lists with the menu and see if we could do something simpler
Emitters self complete when used with @output
…ature is complete
hasSubmenu specifies that it refers to the menu it opens and not its parent
aria-checked Getter property generates more code than a getter function - prefer to use a function.
Contributor
Author
|
@jelbourn all feedback should be addressed now |
jelbourn
approved these changes
Jun 11, 2020
jelbourn
left a comment
jelbourn
left a comment
Contributor
There was a problem hiding this comment.
LGTM aside from one small comment
jelbourn
added
lgtm
target: patch
jelbourn
added
action: merge
andrewseguin
pushed a commit
that referenced
this pull request
Jun 12, 2020
) * feat(cdk-experimental/menu): Add menu skeleton and build scripts Configure bazel scripts for a cdk menu feature along with the general structure identifying the set of directives which make it up * feat(cdk-experimental/menu): Configure dev-app Configure dev-app for cdk-experimental/menu * build: Allow indirect circular dependency between menu and menu-item A CdkMenuItem opens a CdkMenuPanel and therefore must reference it. A CdkMenuPanel contains a CdkMenu and therefore must reference it. A CdkMenu contains CdkMenuItem's and therefore must reference it. * feat(cdk-experimental/menu): Quote all host keys * feat(cdk-experimental/menu): Add missing aria-attributes * feat(cdk-experimental/menu): Clear up CdkMenuItem comment * feat(cdk-experimental/menu): Remove unused build dep * feat(cdk-experimental/menu): Fix codeowners Move from material-experimental section to cdk-experimental * feat(cdk-experimental/menu): Grammer fix * feat(cdk-experimental/menu): explicitly specify the return when null and boolean * feat(cdk-experimental/menu): Clear up documentation/comments * feat(cdk-experimental/menu): Make cdkMenuOrientation comment more clear * feat(cdk-experimental/menu): Make orientation attribute public for consistency * feat(cdk-experimental/menu): Remove unnecessary comment for role binding * feat(cdk-experimental/menu): Fix orientation attribute on host binding typo * feat(cdk-experimental/menu): Refactor `orientation` property comment for clarity * feat(cdk-experimental/menu): Refactor event emitter types Emitters self complete when used with @output * feat(cdk-experimental/menu): Remove documentation to be added once feature is complete * feat(cdk-experimental/menu): Rename opensMenu method hasSubmenu specifies that it refers to the menu it opens and not its parent * feat(cdk-experimental/menu): Use getter function not property for aria-checked Getter property generates more code than a getter function - prefer to use a function. * feat(cdk-experimental/menu): refactor MenuGroup doc for clarity * feat(cdk-experimental/menu): add @jelbourn to CODEOWNERS for cdk-experimental/menu * feat(cdk-experimental/menu): coerce MenuItem checked state to boolean * feat(cdk-experimental/menu): nit: rename val to value
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a skeleton for a new set of directives which implement the Menu and MenuBar pattern in cdk-experimental along with configuring the dev-app for it.