Skip to content

fix(drag-drop): placeholder element not available in started event - #19493

Merged
jelbourn merged 1 commit into
angular:masterfrom
crisbeto:19457/drag-drop-start-event-placeholder
Jun 29, 2020
Merged

fix(drag-drop): placeholder element not available in started event#19493
jelbourn merged 1 commit into
angular:masterfrom
crisbeto:19457/drag-drop-start-event-placeholder

Conversation

@crisbeto

@crisbeto crisbeto commented May 31, 2020

Copy link
Copy Markdown
Member

Fixes calling CdkDrag.getPlaceholderElement returning undefined if it's called in the cdkDragStarted event.

Fixes #19457.

@crisbeto
fix(drag-drop): placeholder element not available in started event
2cd69d7 
Fixes calling `CdkDrag.getPlaceholderElement` returning undefined if it's called in the `cdkDragStarted` event.

Fixes angular#19457.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels May 31, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 31, 2020
crisbeto
crisbeto commented May 31, 2020
View reviewed changes
Comment thread src/cdk/drag-drop/directives/drag.ts
* Returns the element that is being used as a placeholder
* while the current element is being dragged.
* @deprecated No longer being used to be removed.
* @breaking-change 11.0.0

@crisbeto crisbeto May 31, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed my mind on deprecating this, because I can see how it can be useful.

jelbourn
jelbourn approved these changes Jun 9, 2020
View reviewed changes

@jelbourn jelbourn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added lgtm action: merge The PR is ready for merge by the caretaker labels Jun 9, 2020
@jelbourn
jelbourn merged commit bc88cc1 into angular:master Jun 29, 2020
jelbourn pushed a commit that referenced this pull request Jun 29, 2020
@crisbeto @jelbourn
fix(drag-drop): placeholder element not available in started event (#…
94d3fda 
…19493)

Fixes calling `CdkDrag.getPlaceholderElement` returning undefined if it's called in the `cdkDragStarted` event.

Fixes #19457.
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Jul 30, 2020

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Jul 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@jelbourn jelbourn jelbourn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@jelbourn jelbourn

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug(drag-drop): cannot get placeholder element on cdkDragStarted

3 participants

@crisbeto @jelbourn @googlebot