Skip to content

fix(markdown-to-html): use regex to match new API #19417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 5, 2020
Merged

fix(markdown-to-html): use regex to match new API #19417

merged 2 commits into from
Jun 5, 2020

Conversation

annieyw
Copy link
Contributor

@annieyw annieyw commented May 21, 2020

Remove trailing comma in example comment.
Replace differentiating between new and old API with regex match instead of .startsWith('{')

@annieyw annieyw requested review from atscott and mmalerba May 21, 2020 21:04
@annieyw annieyw requested a review from a team as a code owner May 21, 2020 21:04
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 21, 2020
mmalerba
mmalerba approved these changes May 27, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the lgtm label May 27, 2020
@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker merge safe labels May 27, 2020
@jelbourn jelbourn added the target: major This PR is targeted for the next major release label Jun 5, 2020
@jelbourn jelbourn merged commit bfaa272 into angular:master Jun 5, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 6, 2020
@annieyw annieyw deleted the test branch November 9, 2020 19:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

@atscott atscott Awaiting requested review from atscott

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@annieyw @mmalerba @jelbourn @googlebot