fix(material-experimental/mdc-radio): avoid hard references to base material components - #19403
Merged
Merged
Conversation
crisbeto
added
P3
googlebot
added
the
cla: yes
…aterial components Currently the MDC radio button doesn't extend the Material one in order to avoid bringing in unecessary code. The problem is that the MDC button group still has a hard reference to the Material `MatRadioButton` which means that we'll likely end up importing it anyway. These changes move the button group code into a base class and remove the references to the Material button.
crisbeto
force-pushed
the
radio-group-reference
branch
from
May 20, 2020 15:36
e4eac13 to
7604301
Compare
devversion
approved these changes
May 21, 2020
jelbourn
pushed a commit
that referenced
this pull request
Jun 5, 2020
…aterial components (#19403) Currently the MDC radio button doesn't extend the Material one in order to avoid bringing in unecessary code. The problem is that the MDC button group still has a hard reference to the Material `MatRadioButton` which means that we'll likely end up importing it anyway. These changes move the button group code into a base class and remove the references to the Material button.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the MDC radio button doesn't extend the Material one in order to avoid bringing in unecessary code. The problem is that the MDC button group still has a hard reference to the Material
MatRadioButtonwhich means that we'll likely end up importing it anyway.These changes move the button group code into a base class and remove the references to the Material button.