Skip to content

Map overlay - #19143

Merged
jelbourn merged 2 commits into
angular:masterfrom
mbehrlich:map-overlay
Apr 23, 2020
Merged

Map overlay#19143
jelbourn merged 2 commits into
angular:masterfrom
mbehrlich:map-overlay

Conversation

@mbehrlich

@mbehrlich mbehrlich commented Apr 22, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@mbehrlich
feat(google-maps): Add Ground Overlay component.
ae0228e 
Add a component that will allow developers to overlay an image over a
Google Map, following the Google Maps JavaScript API as in
developers.google.com/maps/documentation/javascript/reference/image-overlay
@mbehrlich
feat(google-maps): Add Ground Overlay component
eeed1e8 
Update the public api with new component.
@mbehrlich
mbehrlich requested a review from a team April 22, 2020 19:21
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 22, 2020
@mbehrlich mbehrlich added the target: minor This PR is targeted for the next minor release label Apr 22, 2020
jelbourn
jelbourn approved these changes Apr 22, 2020
View reviewed changes

@jelbourn jelbourn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed lgtm action: merge The PR is ready for merge by the caretaker labels Apr 22, 2020
@jelbourn
jelbourn merged commit eba622a into angular:master Apr 23, 2020
soro-google pushed a commit to soro-google/components that referenced this pull request Apr 24, 2020
@mbehrlich @soro-google
feat(google-maps): add ground overlay component (angular#19143)
03d7b4f 
Add a component that will allow developers to overlay an image over a
Google Map, following the Google Maps JavaScript API as in
developers.google.com/maps/documentation/javascript/reference/image-overlay
@francovp

francovp commented May 4, 2020

Copy link
Copy Markdown

Hello, In which version can I get this?

@jelbourn

jelbourn commented May 4, 2020

Copy link
Copy Markdown
Contributor

This feature will end up landing in 10.0.0 (and all of the -next and -rc pre-releases)

@francovp

francovp commented May 5, 2020 •
edited
Loading

Copy link
Copy Markdown

Oh,
Any idea how can I add this feature on a production-ready Angular 9 project?

@jelbourn

jelbourn commented May 6, 2020

Copy link
Copy Markdown
Contributor

There's https://github.com/angular/google-maps-builds, but the builds there have zero guarantee of stability.

@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Jun 6, 2020

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Jun 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@jelbourn jelbourn jelbourn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@jelbourn jelbourn

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mbehrlich @francovp @jelbourn @googlebot