Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(platform): avoid errors if ShadowRoot is not defined #19124

Merged
merged 1 commit into from
Apr 23, 2020
Merged

fix(platform): avoid errors if ShadowRoot is not defined #19124

merged 1 commit into from
Apr 23, 2020

Conversation

crisbeto
Copy link
Member

Fixes potential errors if the ShadowRoot global is undefined.

@crisbeto
fix(platform): avoid errors if ShadowRoot is not defined
15def5f 
Fixes potential errors if the `ShadowRoot` global is undefined.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent G This is is related to a Google internal issue target: patch This PR is targeted for the next patch release labels Apr 20, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 20, 2020
@andrewseguin andrewseguin added P2 The issue is important to a large percentage of users, with a workaround and removed P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Apr 20, 2020
@andrewseguin
Copy link
Contributor

LGTM

@crisbeto crisbeto added lgtm action: merge The PR is ready for merge by the caretaker labels Apr 20, 2020
devversion
devversion approved these changes Apr 20, 2020
View reviewed changes
Copy link
Member

@devversion devversion left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we capture this in the universal-app somehow?

Edit: For later reference: Looks like this could not be reproduced, so we can't have tests for it.

@jelbourn jelbourn merged commit 46babbd into angular:master Apr 23, 2020
jelbourn pushed a commit that referenced this pull request Apr 23, 2020
@crisbeto @jelbourn
fix(platform): avoid errors if ShadowRoot is not defined (#19124)
874c754 
Fixes potential errors if the `ShadowRoot` global is undefined.
soro-google pushed a commit to soro-google/components that referenced this pull request Apr 24, 2020
@crisbeto @soro-google
fix(platform): avoid errors if ShadowRoot is not defined (angular#19124)
379f83c 
Fixes potential errors if the `ShadowRoot` global is undefined.
@snyk-bot snyk-bot mentioned this pull request May 3, 2020
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewseguin andrewseguin andrewseguin approved these changes

@devversion devversion devversion approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@andrewseguin andrewseguin

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crisbeto @andrewseguin @devversion @jelbourn @googlebot