Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select/testing): incorrect options if multiple selects are on the page at the same time #19112

Merged

Conversation

crisbeto
Copy link
Member

Fixes the test harness always retrieving the options for the first select when there are multiple selects on the page.

Fixes #19075.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Apr 19, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 19, 2020
@crisbeto crisbeto force-pushed the 19075/multiple-select-incorrect-options branch from 70460e9 to ff67201 Compare April 19, 2020 10:46
… page at the same time

Fixes the test harness always retrieving the options for the first select when there are multiple selects on the page.

Fixes angular#19075.
@crisbeto crisbeto force-pushed the 19075/multiple-select-incorrect-options branch from ff67201 to caf92ce Compare April 19, 2020 10:48
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added lgtm action: merge The PR is ready for merge by the caretaker labels Apr 21, 2020
@jelbourn jelbourn merged commit e46afe8 into angular:master Apr 23, 2020
jelbourn pushed a commit that referenced this pull request Apr 23, 2020
… page at the same time (#19112)

Fixes the test harness always retrieving the options for the first select when there are multiple selects on the page.

Fixes #19075.
soro-google pushed a commit to soro-google/components that referenced this pull request Apr 24, 2020
… page at the same time (angular#19112)

Fixes the test harness always retrieving the options for the first select when there are multiple selects on the page.

Fixes angular#19075.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug with testing MatSelect using getHarness and getOptions
4 participants