Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: convert stylelint rules to typescript #19047

Merged
merged 1 commit into from
Apr 17, 2020
Merged

build: convert stylelint rules to typescript #19047

merged 1 commit into from
Apr 17, 2020

Conversation

crisbeto
Copy link
Member

Converts the Stylelint rules to TypeScript so they're in line with the rest of the project and to make it easier to work with the PostCSS AST.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: patch This PR is targeted for the next patch release labels Apr 11, 2020
@crisbeto crisbeto requested review from jelbourn and a team as code owners April 11, 2020 08:53
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 11, 2020
devversion
devversion approved these changes Apr 13, 2020
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

tools/stylelint/no-concrete-rules.ts Show resolved Hide resolved
package.json Show resolved Hide resolved
@crisbeto
build: convert stylelint rules to typescript
d51dc91 
Converts the Stylelint rules to TypeScript so they're in line with the rest of the project and to make it easier to work with the PostCSS AST.
@crisbeto
Copy link
Member Author

I've addressed the feedback @devversion.

@devversion devversion added lgtm action: merge The PR is ready for merge by the caretaker labels Apr 14, 2020
@andrewseguin andrewseguin merged commit 313e3f3 into angular:master Apr 17, 2020
andrewseguin pushed a commit that referenced this pull request Apr 17, 2020
@crisbeto @andrewseguin
build: convert stylelint rules to typescript (#19047)
cbfba2d 
Converts the Stylelint rules to TypeScript so they're in line with the rest of the project and to make it easier to work with the PostCSS AST.

(cherry picked from commit 313e3f3)
soro-google pushed a commit to soro-google/components that referenced this pull request Apr 24, 2020
@crisbeto @soro-google
build: convert stylelint rules to typescript (angular#19047)
e6db9dd 
Converts the Stylelint rules to TypeScript so they're in line with the rest of the project and to make it easier to work with the PostCSS AST.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@jelbourn jelbourn

@devversion devversion

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crisbeto @devversion @jelbourn @googlebot @andrewseguin