Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update to latest MDC canary version and fix error #19026

Merged
merged 1 commit into from
Apr 9, 2020
Merged

build: update to latest MDC canary version and fix error #19026

merged 1 commit into from
Apr 9, 2020

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Apr 8, 2020

Updates to the latest Canary version of MDC and fixes a build error that was caught by the CI.

@crisbeto
build: update to latest MDC canary version and fix error
71238b9 
Updates to the latest Canary version of MDC and fixes a build error that was caught by the CI.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround merge safe target: patch This PR is targeted for the next patch release labels Apr 8, 2020
@crisbeto crisbeto requested review from jelbourn, mmalerba and a team as code owners April 8, 2020 20:26
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 8, 2020
mmalerba
mmalerba approved these changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added lgtm action: merge The PR is ready for merge by the caretaker labels Apr 8, 2020
@mmalerba mmalerba merged commit 239e01d into angular:master Apr 9, 2020
mmalerba pushed a commit that referenced this pull request Apr 14, 2020
@crisbeto @mmalerba
build: update to latest MDC canary version and fix error (#19026)
e28cd37 
Updates to the latest Canary version of MDC and fixes a build error that was caught by the CI.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

@devversion devversion devversion approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @devversion @mmalerba @googlebot