Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material-experimental/mdc-table): not supporting multiple themes #18931

Merged
merged 1 commit into from
Apr 17, 2020
Merged

fix(material-experimental/mdc-table): not supporting multiple themes #18931

merged 1 commit into from
Apr 17, 2020

Conversation

crisbeto
Copy link
Member

The theming for the MDC table wasn't set up completely which meant that it only works with one theme.

Note: this is blocked on material-components/material-components-web#5751, but is otherwise code-complete.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent blocked This issue is blocked by some external factor, such as a prerequisite PR merge safe target: patch This PR is targeted for the next patch release labels Mar 26, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 26, 2020
mmalerba
mmalerba approved these changes Mar 27, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto requested review from jelbourn and a team as code owners April 2, 2020 16:25
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed blocked This issue is blocked by some external factor, such as a prerequisite PR labels Apr 2, 2020
@crisbeto
Copy link
Member Author

crisbeto commented Apr 2, 2020

This isn't blocked anymore.

@crisbeto
fix(material-experimental/mdc-table): not supporting multiple themes
694fbd9 
The theming for the MDC table wasn't set up completely which meant that it only works with one theme.
@andrewseguin andrewseguin merged commit 447f2e6 into angular:master Apr 17, 2020
andrewseguin pushed a commit that referenced this pull request Apr 17, 2020
@crisbeto @andrewseguin
fix(material-experimental/mdc-table): not supporting multiple themes (#…
d564f6e 
…18931)

The theming for the MDC table wasn't set up completely which meant that it only works with one theme.

(cherry picked from commit 447f2e6)
soro-google pushed a commit to soro-google/components that referenced this pull request Apr 24, 2020
@crisbeto @soro-google
fix(material-experimental/mdc-table): not supporting multiple themes (a…
7e5d8eb 
…ngular#18931)

The theming for the MDC table wasn't set up completely which meant that it only works with one theme.
@snyk-bot snyk-bot mentioned this pull request May 3, 2020
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

@devversion devversion devversion approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@mmalerba mmalerba

@andrewseguin andrewseguin

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crisbeto @devversion @mmalerba @googlebot @andrewseguin