Skip to content

build: setup snapshot builds for experimental and new packages #18736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

devversion
Copy link
Member

@devversion devversion commented Mar 6, 2020

  • Sets up snapshot builds for the experimental packages
  • Sets up snapshot builds for the new packages (google-maps, youtube-player)
  • Updates snapshot builds repositories to match package name. Similar to how it is done in
    framework, and to improve consistency. This means that:
    • material2-builds becomes material-builds
    • material2-moment-adapter becomes material-moment-adapter.

We can do the rename because Github creates repository redirects. This should prevent breakages for people relying on the builds repositories. Though we never denoted those as public.

@jelbourn @josephperrott If we go with renaming these old build repositories for consistency, then the following things would need to be made:

  1. Delete the newly created material-moment-adapter-builds repo.
  2. Rename material2-moment-adapter-builds repo to material-moment-adapter-builds
  3. Rename material2-builds to material-builds.

* Sets up snapshot builds for the experimental packages
* Sets up snapshot builds for the new packages (`google-maps`, `youtube-player`)

* Updates snapshot builds repositories to match package name. Similar to
  how it is done in framework, and to improve consistency. This means
  that: `material2-builds` becomes `material-builds`, and
  `material2-moment-adapter` becomes `material-moment-adapter`.
@devversion devversion added merge safe target: patch This PR is targeted for the next patch release labels Mar 6, 2020
@devversion devversion requested a review from a team as a code owner March 6, 2020 14:20
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 6, 2020
@josephperrott
Copy link
Member

I am good with your proposal, but we should have @jelbourn sign off as well.

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, you can add "merge ready" once Joey can make the repo changes

@jelbourn jelbourn added the lgtm label Mar 9, 2020
@josephperrott
Copy link
Member

Updating github repos now, and then I will merge this PR.

@josephperrott josephperrott added the action: merge The PR is ready for merge by the caretaker label Mar 10, 2020
@josephperrott josephperrott merged commit 59ae34b into angular:master Mar 10, 2020
timsawyer pushed a commit to timsawyer/components that referenced this pull request Mar 10, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants