-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: upload release packages as job artifacts for PRs #18710
build: upload release packages as job artifacts for PRs #18710
Conversation
238417a
to
8791002
Compare
Example artifacts have been uploaded for this PR here. Credits for this idea go to @gkalpak. This has been implemented in I'm unsure about costs for CircleCI. Maybe @josephperrott knows more? |
Upload release packages as job artifacts for PRs. This allows us to easily check out changes from a PR locally, without having to manually check-out the branch, and building the release output. Co-authored-by: George Kalpakas <kalpakas.g@gmail.com>
8791002
to
2c55217
Compare
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
Suffix should match docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
@devversion can to file an issue for devinfra to share a single script for all repos for this? |
* build: upload release packages as job artifacts for PRs Upload release packages as job artifacts for PRs. This allows us to easily check out changes from a PR locally, without having to manually check-out the branch, and building the release output. Co-authored-by: George Kalpakas <kalpakas.g@gmail.com> * fixup! build: upload release packages as job artifacts for PRs Suffix should match docs Co-authored-by: George Kalpakas <kalpakas.g@gmail.com>
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Upload release packages as job artifacts for PRs. This allows
us to easily check out changes from a PR locally, without having
to manually check-out the branch, and building the release output.