Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upload release packages as job artifacts for PRs #18710

Merged

Conversation

devversion
Copy link
Member

Upload release packages as job artifacts for PRs. This allows
us to easily check out changes from a PR locally, without having
to manually check-out the branch, and building the release output.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 4, 2020
@devversion devversion force-pushed the build/upload-release-archives-prs branch 3 times, most recently from 238417a to 8791002 Compare March 4, 2020 19:24
@devversion
Copy link
Member Author

devversion commented Mar 4, 2020

Example artifacts have been uploaded for this PR here. Credits for this idea go to @gkalpak. This has been implemented in angular/angular too. We should add some docs for this too, if we decide to merge it.

I'm unsure about costs for CircleCI. Maybe @josephperrott knows more?

@devversion devversion added merge safe target: patch This PR is targeted for the next patch release labels Mar 4, 2020
@devversion devversion marked this pull request as ready for review March 4, 2020 19:47
@devversion devversion requested a review from a team as a code owner March 4, 2020 19:47
@gkalpak
Copy link
Member

gkalpak commented Mar 4, 2020

🚀

FYI, we have some docs about it here.

FWIW, here is the original discussion about cost (internal link)

Upload release packages as job artifacts for PRs. This allows
us to easily check out changes from a PR locally, without having
to manually check-out the branch, and building the release output.

Co-authored-by: George Kalpakas <kalpakas.g@gmail.com>
@devversion devversion force-pushed the build/upload-release-archives-prs branch from 8791002 to 2c55217 Compare March 5, 2020 10:13
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Mar 5, 2020
@devversion
Copy link
Member Author

Thanks @gkalpak. I've used the docs you wrote on framework (with adjustments for this repo). Also thanks for linking the discussion about the costs of using job artifacts.

I think in the future we can have the scripts and docs shared in the dev-infra package. Created DEV-62

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added cla: yes PR author has agreed to Google's Contributor License Agreement lgtm action: merge The PR is ready for merge by the caretaker and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Mar 5, 2020
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@jelbourn
Copy link
Member

jelbourn commented Mar 5, 2020

@devversion can to file an issue for devinfra to share a single script for all repos for this?

@devversion
Copy link
Member Author

@jelbourn Yeah, already did this. See: DEV-62

@mmalerba mmalerba merged commit cf13ecb into angular:master Mar 5, 2020
mmalerba added a commit that referenced this pull request Mar 6, 2020
* build: upload release packages as job artifacts for PRs

Upload release packages as job artifacts for PRs. This allows
us to easily check out changes from a PR locally, without having
to manually check-out the branch, and building the release output.

Co-authored-by: George Kalpakas <kalpakas.g@gmail.com>

* fixup! build: upload release packages as job artifacts for PRs

Suffix should match docs

Co-authored-by: George Kalpakas <kalpakas.g@gmail.com>
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants