Conversation
This is similar to trackBy in *ngFor and is critical for those of us who use the redux pattern (i.e. NGRX) since we frequently replace our node references with modified copies from the Store (as opposed to changing the state within the node objects themselves)
Contributor
|
Two comments:
To resolve this, we can add a new type You can take the code from this commit and apply it to this PR and verify that it fits your use case: andrewseguin@d0c1089 |
added 2 commits
March 23, 2020 15:39
Author
|
Hi! Thank you for the suggested changes - I've applied them, but I'm not sure what these failing CircleCI tests are |
Contributor
|
added 2 commits
April 13, 2020 16:08
Author
|
Hello! Fixed up the failing tests, I'm not sure what that last check is though. |
soro-google
pushed a commit
to soro-google/components
that referenced
this pull request
Apr 24, 2020
…18708) This is similar to trackBy in *ngFor and is important for those who use the redux pattern (i.e. NGRX) since node references are frequently replaced with modifies instances from the Store (as opposed to changing the state within the node objects themselves)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is similar to trackBy in *ngFor and is critical for those of us who
use the redux pattern (i.e. NGRX) since we frequently replace our node references with
modified copies from the Store (as opposed to changing the state within the node objects
themselves)