feat(datepicker): initial styling for date range - #18369
Merged
Merged
Conversation
crisbeto
added
P3
googlebot
added
the
cla: yes
mmalerba
reviewed
Feb 4, 2020
mmalerba
left a comment
mmalerba
left a comment
Contributor
There was a problem hiding this comment.
I noticed that this breaks the hover and focus styles for the single date calendar
mmalerba
reviewed
Feb 4, 2020
Reworks a few things in the calendar and adds the styling for the date range. A couple of notes: * This isn't the final UX of when start/end ranges will be selected. I wanted to have most of the functionality in place before playing around with the UX. * This approach currently has an issue where the range won't go from one month into another properly. The problem is that the date cells store the current day internally. I'll make a follow-up PR that'll address the issue by storing the timestamp instead.
crisbeto
force-pushed
the
date-range-styling
branch
from
February 5, 2020 06:11
7214416 to
88962bf
Compare
Member
Author
|
Good catch about the hover/focus styling, I totally missed that. It also made me realize that the date range selection styles didn't work when selecting with the keyboard. It should all be fixed now, together with the rest of the feedback. |
crisbeto
added a commit
that referenced
this pull request
Feb 5, 2020
Reworks a few things in the calendar and adds the styling for the date range. A couple of notes: * This isn't the final UX of when start/end ranges will be selected. I wanted to have most of the functionality in place before playing around with the UX. * This approach currently has an issue where the range won't go from one month into another properly. The problem is that the date cells store the current day internally. I'll make a follow-up PR that'll address the issue by storing the timestamp instead.
crisbeto
added a commit
that referenced
this pull request
Feb 17, 2020
Reworks a few things in the calendar and adds the styling for the date range. A couple of notes: * This isn't the final UX of when start/end ranges will be selected. I wanted to have most of the functionality in place before playing around with the UX. * This approach currently has an issue where the range won't go from one month into another properly. The problem is that the date cells store the current day internally. I'll make a follow-up PR that'll address the issue by storing the timestamp instead.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Feb 17, 2020
Reworks a few things in the calendar and adds the styling for the date range. A couple of notes: * This isn't the final UX of when start/end ranges will be selected. I wanted to have most of the functionality in place before playing around with the UX. * This approach currently has an issue where the range won't go from one month into another properly. The problem is that the date cells store the current day internally. I'll make a follow-up PR that'll address the issue by storing the timestamp instead.
crisbeto
added a commit
that referenced
this pull request
Feb 26, 2020
Reworks a few things in the calendar and adds the styling for the date range. A couple of notes: * This isn't the final UX of when start/end ranges will be selected. I wanted to have most of the functionality in place before playing around with the UX. * This approach currently has an issue where the range won't go from one month into another properly. The problem is that the date cells store the current day internally. I'll make a follow-up PR that'll address the issue by storing the timestamp instead.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworks a few things in the calendar and adds the styling for the date range. A couple of notes: