Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update dev environment instructions #18359

Merged
merged 1 commit into from
Feb 4, 2020

Conversation

crisbeto
Copy link
Member

Updates the dev environment instructions to mention how to run tests properly.

Also removes global Gulp as a required step for setting up the environment and changes the Gulp commands to go through yarn.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent docs This issue is related to documentation pr: merge safe target: patch This PR is targeted for the next patch release labels Jan 31, 2020
@crisbeto crisbeto requested review from jelbourn and a team as code owners January 31, 2020 22:00
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 31, 2020
DEV_ENVIRONMENT.md Outdated Show resolved Hide resolved
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

DEV_ENVIRONMENT.md Outdated Show resolved Hide resolved
DEV_ENVIRONMENT.md Outdated Show resolved Hide resolved
DEV_ENVIRONMENT.md Show resolved Hide resolved
@crisbeto
Copy link
Member Author

I've addressed the feedback.

@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 31, 2020
@ngbot
Copy link

ngbot bot commented Jan 31, 2020

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: e2e_tests" is failing
    pending status "ci/circleci: tests_saucelabs" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

DEV_ENVIRONMENT.md Outdated Show resolved Hide resolved
Updates the dev environment instructions to mention how to run tests properly.

Also removes global Gulp as a required step for setting up the environment and changes the Gulp commands to go through yarn.
Copy link
Member

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba merged commit 22d7cf6 into angular:master Feb 4, 2020
mmalerba pushed a commit that referenced this pull request Feb 5, 2020
Updates the dev environment instructions to mention how to run tests properly.

Also removes global Gulp as a required step for setting up the environment and changes the Gulp commands to go through yarn.
yifange pushed a commit to yifange/components that referenced this pull request Feb 6, 2020
Updates the dev environment instructions to mention how to run tests properly.

Also removes global Gulp as a required step for setting up the environment and changes the Gulp commands to go through yarn.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants