-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update dev environment instructions #18359
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
0b26384
to
9cf7ba6
Compare
I've addressed the feedback. |
Updates the dev environment instructions to mention how to run tests properly. Also removes global Gulp as a required step for setting up the environment and changes the Gulp commands to go through yarn.
9cf7ba6
to
6d63f3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Updates the dev environment instructions to mention how to run tests properly. Also removes global Gulp as a required step for setting up the environment and changes the Gulp commands to go through yarn.
Updates the dev environment instructions to mention how to run tests properly. Also removes global Gulp as a required step for setting up the environment and changes the Gulp commands to go through yarn.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Updates the dev environment instructions to mention how to run tests properly.
Also removes global Gulp as a required step for setting up the environment and changes the Gulp commands to go through yarn.