chore: analyze travis commit and check for blocked statements. #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
force-pushed
the
chore/travis-commit-analyze
branch
2 times, most recently
from
be2344a to
64930ee
Compare
| @@ -0,0 +1,30 @@ | |||
| 'use strict'; | |||
There was a problem hiding this comment.
I wonder if this would be faster with a bash script that directly greps the output of the git diff.
@hansl what do you think? (it's probably a trivial difference, though)
There was a problem hiding this comment.
@jelbourn In bash, this would require more work with the multiple lines. Since the bash output strips the line delimiters out. I don't say this won't work, but it would require more work and wouldn't be that elegant as in node.
devversion
force-pushed
the
chore/travis-commit-analyze
branch
from
64930ee to
0662d79
Compare
|
LGTM |
andrewseguin
pushed a commit
to andrewseguin/components
that referenced
this pull request
Oct 15, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attention: The CI is failing, because of the changes itself.
Fixes #175.