Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: describe dev-env setup for Windows machines #17467

Merged
merged 3 commits into from
Oct 25, 2019
Merged

docs: describe dev-env setup for Windows machines #17467

merged 3 commits into from
Oct 25, 2019

Conversation

JanMalch
Copy link
Contributor

Windows machines do not have the required patch command available.
The added step explains how to install the package on Windows.

Refs #17456

Windows machines do not have the required patch command available.
The added step explains how to install the package on Windows.

Refs #17456
@JanMalch JanMalch requested review from jelbourn and a team as code owners October 22, 2019 19:31
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 22, 2019
@josephperrott
Copy link
Member

Assigning @devversion as the windows expert.

Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! One optional comment.

DEV_ENVIRONMENT.md Outdated Show resolved Hide resolved
@devversion devversion added pr: lgtm target: patch This PR is targeted for the next patch release labels Oct 23, 2019
DEV_ENVIRONMENT.md Outdated Show resolved Hide resolved
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for this PR, I should came back and expand this doc a bit more sometime soon

@jelbourn jelbourn added action: merge The PR is ready for merge by the caretaker P4 A relatively minor issue that is not relevant to core functions docs This issue is related to documentation labels Oct 25, 2019
@mmalerba mmalerba merged commit 0d29f4d into angular:master Oct 25, 2019
@JanMalch JanMalch deleted the dev-env-setup branch October 26, 2019 13:08
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants