fix(form-field): ensure that descendants are picked up in Ivy - #17439
Merged
Conversation
Since there's a slight difference in how `ContentChildren` works in Ivy, these changes add the `descendants` flag explicitly to ensure that we pick up all of the relevant elements. Note that we shouldn't need any extra logic, because nesting form fields is invalid.
crisbeto
added
P2
googlebot
added
the
cla: yes
mmalerba
added
P1
mmalerba
approved these changes
Oct 17, 2019
mmalerba
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since there's a slight difference in how
ContentChildrenworks in Ivy, these changes add thedescendantsflag explicitly to ensure that we pick up all of the relevant elements. Note that we shouldn't need any extra logic, because nesting form fields is invalid.